Skip to content

Automate draft release #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Automate draft release #1623

merged 1 commit into from
May 12, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented May 11, 2020

No description provided.

@nhooyr nhooyr requested a review from code-asher as a code owner May 11, 2020 21:08
@nhooyr nhooyr force-pushed the automate-release branch 5 times, most recently from ebc9778 to 98a168d Compare May 11, 2020 22:55
1. Run `yarn release:github-draft` to create a GitHub draft release from the template with
the updated version.
1. Summarize the major changes in the release notes and link to the relevant issues.
1. Wait for the artifacts in step 2 to build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we number these incrementally instead of just with 1? Normally I don't pay much attention but since we called out step 2 I was trying to count up in my head and got lost a couple times lol especially since Github is rendering a gap after 2 for some reason and I kept thinking it was a separate paragraph. I always read the readmes raw so maybe that's just a me problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually in markdown you don't want to number them to avoid forgetting updates since when it renders it's immediately there but I agree it is nice when looking at the raw markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I see no gap after 2, that's weird.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must have something to do with the specific screen size I have my browser at. My editor automatically updates the numbers so I was hoping there was something similar for yours.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goland aint as cool as emacs :(

--draft "${assets[@]}" "v$(pkg_json_version)" << EOF
v$(pkg_json_version)

VS Code v$(vscode_version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@nhooyr nhooyr force-pushed the automate-release branch from 98a168d to 169f8c6 Compare May 12, 2020 01:00
@nhooyr nhooyr merged commit 2e31e8f into master May 12, 2020
@nhooyr nhooyr deleted the automate-release branch May 12, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants